KJ16609/gcc-reflection
1
0
Fork 0
mirror of https://forge.sourceware.org/marek/gcc.git synced 2026-02-22 03:47:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Speed up wide_int_storage::operator=(wide_int_storage const&)

Browse Source 
wide_int_storage shows up high in the profile for the testcase in
PR114855 where the apparent issue is that the conditional jump
on 'precision' after the (inlined) memcpy stalls the pipeline due
to the data dependence and required store-to-load forwarding.  We
can add scheduling freedom by instead testing precision as from the
source which speeds up the function by 30%.  I've applied the
same logic to the copy CTOR.

	* wide-int.h (wide_int_storage::wide_int_storage): Branch
	on source precision to avoid data dependence on memcpy
	destination.
	(wide_int_storage::operator=): Likewise.
This commit is contained in:
Richard Biener
2024-09-25 13:15:42 +02:00
committed by Richard Biener
parent 1fea6f8248
commit 6efc770a71
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/wide-int.h
View File

@@ -1196,7 +1196,7 @@ inline wide_int_storage::wide_int_storage (const T &x)
inline wide_int_storage::wide_int_storage (const wide_int_storage &x)
{
memcpy (this, &x, sizeof (wide_int_storage));
if (UNLIKELY (precision > WIDE_INT_MAX_INL_PRECISION))
if (UNLIKELY (x.precision > WIDE_INT_MAX_INL_PRECISION))
{
u.valp = XNEWVEC (HOST_WIDE_INT, CEIL (precision, HOST_BITS_PER_WIDE_INT));
memcpy (u.valp, x.u.valp, len * sizeof (HOST_WIDE_INT));
@@ -1219,9 +1219,9 @@ wide_int_storage::operator = (const wide_int_storage &x)
XDELETEVEC (u.valp);
}
memcpy (this, &x, sizeof (wide_int_storage));
if (UNLIKELY (precision > WIDE_INT_MAX_INL_PRECISION))
if (UNLIKELY (x.precision > WIDE_INT_MAX_INL_PRECISION))
{
u.valp = XNEWVEC (HOST_WIDE_INT, CEIL (precision, HOST_BITS_PER_WIDE_INT));
u.valp = XNEWVEC (HOST_WIDE_INT, CEIL (x.precision, HOST_BITS_PER_WIDE_INT));
memcpy (u.valp, x.u.valp, len * sizeof (HOST_WIDE_INT));
}
return *this;