KJ16609/gcc
1
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2026-02-22 20:01:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

gccrs: Add capture tracking to the type info for closures

Browse Source 
gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Pass captures
	properly to `TyTy::ClosureType` constructor.
	* typecheck/rust-tyty.cc (ClosureType::as_string): Fix string representation.
	(ClosureType::clone): Pass `captures` argument.
	* typecheck/rust-tyty.h: Add `captures` field.
This commit is contained in:
Philip Herron
2022-10-21 15:39:52 +01:00
committed by Arthur Cohen
parent f7c258b291
commit eb1202224f
3 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/rust/typecheck/rust-hir-type-check-expr.cc
View File

@@ -1492,8 +1492,10 @@ TypeCheckExpr::visit (HIR::ClosureExpr &expr)
expr.get_locus ());
// generate the closure type
NodeId closure_node_id = expr.get_mappings ().get_nodeid ();
const std::set<NodeId> &captures = resolver->get_captures (closure_node_id);
infered = new TyTy::ClosureType (ref, id, ident, closure_args, result_type,
subst_refs);
subst_refs, captures);
// FIXME
// all closures automatically inherit the appropriate fn trait. Lets just

5
gcc/rust/typecheck/rust-tyty.cc
View File

@@ -1675,8 +1675,7 @@ std::string
ClosureType::as_string () const
{
std::string params_buf = parameters->as_string ();
return "|" + params_buf + "| {" + result_type.get_tyty ()->as_string ()
+ "} {" + raw_bounds_as_string () + "}";
return "|" + params_buf + "| {" + result_type.get_tyty ()->as_string () + "}";
}
BaseType *
@@ -1714,7 +1713,7 @@ ClosureType::clone () const
{
return new ClosureType (get_ref (), get_ty_ref (), ident, id,
(TyTy::TupleType *) parameters->clone (), result_type,
clone_substs (), get_combined_refs (),
clone_substs (), captures, get_combined_refs (),
specified_bounds);
}

11
gcc/rust/typecheck/rust-tyty.h
View File

@@ -1628,13 +1628,15 @@ public:
ClosureType (HirId ref, DefId id, RustIdent ident,
TyTy::TupleType *parameters, TyVar result_type,
std::vector<SubstitutionParamMapping> subst_refs,
std::set<NodeId> captures,
std::set<HirId> refs = std::set<HirId> (),
std::vector<TypeBoundPredicate> specified_bounds
= std::vector<TypeBoundPredicate> ())
: BaseType (ref, ref, TypeKind::CLOSURE, ident, refs),
SubstitutionRef (std::move (subst_refs),
SubstitutionArgumentMappings::error ()),
parameters (parameters), result_type (std::move (result_type)), id (id)
parameters (parameters), result_type (std::move (result_type)), id (id),
captures (captures)
{
LocalDefId local_def_id = id.localDefId;
rust_assert (local_def_id != UNKNOWN_LOCAL_DEFID);
@@ -1644,13 +1646,15 @@ public:
ClosureType (HirId ref, HirId ty_ref, RustIdent ident, DefId id,
TyTy::TupleType *parameters, TyVar result_type,
std::vector<SubstitutionParamMapping> subst_refs,
std::set<NodeId> captures,
std::set<HirId> refs = std::set<HirId> (),
std::vector<TypeBoundPredicate> specified_bounds
= std::vector<TypeBoundPredicate> ())
: BaseType (ref, ty_ref, TypeKind::CLOSURE, ident, refs),
SubstitutionRef (std::move (subst_refs),
SubstitutionArgumentMappings::error ()),
parameters (parameters), result_type (std::move (result_type)), id (id)
parameters (parameters), result_type (std::move (result_type)), id (id),
captures (captures)
{
LocalDefId local_def_id = id.localDefId;
rust_assert (local_def_id != UNKNOWN_LOCAL_DEFID);
@@ -1699,10 +1703,13 @@ public:
void setup_fn_once_output () const;
const std::set<NodeId> &get_captures () const { return captures; }
private:
TyTy::TupleType *parameters;
TyVar result_type;
DefId id;
std::set<NodeId> captures;
};
class ArrayType : public BaseType