KJ16609/gcc
1
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2026-02-23 04:09:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

c++: Windows rename [PR 98412]

Browse Source 
Some system's rename(2) fails if the target already exists, so delete it
first.

	gcc/cp/
	* module.cc (create_dirs): Add logging.
	(finish_module_processing): Unlink before rename.
This commit is contained in:
Nathan Sidwell
2020-12-21 09:48:28 -08:00
parent 1467a5c5ab
commit e798f08192
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gcc/cp/module.cc
View File

@@ -4693,6 +4693,7 @@ create_dirs (char *path)
char sep = *base;
*base = 0;
int failed = mkdir (path, S_IRWXU | S_IRWXG | S_IRWXO);
dump () && dump ("Mkdir ('%s') errno:=%u", path, failed ? errno : 0);
*base = sep;
if (failed
/* Maybe racing with another creator (of a *different*
@@ -19744,8 +19745,17 @@ finish_module_processing (cpp_reader *reader)
input_location = loc;
}
if (to.end ())
if (rename (tmp_name, path))
to.set_error (errno);
{
/* Some OS's do not replace NEWNAME if it already
exists. This'll have a race condition in erroneous
concurrent builds. */
unlink (path);
if (rename (tmp_name, path))
{
dump () && dump ("Rename ('%s','%s') errno=%u", errno);
to.set_error (errno);
}
}
if (to.get_error ())
{